methodgg / wago.io

Code for website wago.io
MIT License
111 stars 40 forks source link

[Feature Request] Webhook updates on encrypted imports #251

Closed macwille closed 1 month ago

macwille commented 1 month ago

I would like to receive updates from the discord webhook but keep my import password protected.

Currently the webhook only work on public imports. Maybe versioning could be tracked without accessing the encrypted import data?

oratory commented 1 month ago

Nothing that the webhook uses is encrypted so that isn't a problem. However webhooks aren't sent for hidden/private/encrypted/restricted imports since the webhook option applies to all imports, so stuff that isn't public aren't sent that way.

Adding a separate webhook override option attached to the individual import could work though, I'll look into that this week.

oratory commented 1 month ago

Completed, imports can now have their own webhook settings (and some other webhook features).

macwille commented 1 month ago

thanks that was fast!