Makehook: fixes improper adding `www.` to redirection domains

joha2 commented 4 years ago

href returned https://www.youtube.com/...
the string replacement only replaces youtube.com by invidous domain given
this leads to a wrong www. in front of some domains
for the original invidio.us domain this did not matter since www.invidio.us works, too

Should solve #20 at least partially.

joha2 commented 4 years ago

@metiis is there anything preventing this PR from being merged?

grondilu commented 3 years ago

Please merge this, the add-on is basically useless otherwise.

N07070 commented 3 years ago

It would be great to merge this

MicroCheapFx commented 3 years ago

Is @metiis around ? Is this project discontinued ?

dschuessler commented 3 years ago

Anyone looking for a working solution: Switch to the Redirector extension (https://github.com/einaregilsson/Redirector). It is a generic redirector. Here is an example configuration for redirecting YouTube links to an invidious instance:

Bildschirmfoto 2021-04-02 um 1 38 02 PM

rzr commented 3 years ago

Is @metiis around ? Is this project discontinued ?

In this case it can be transfered to @abandonware org for community maintenance

see how:

https://rzr.github.io/rzr-presentations/docs/abandonware

halictuz commented 2 years ago

Anyone looking for a working solution: Switch to the Redirector extension (https://github.com/einaregilsson/Redirector). It is a generic redirector. Here is an example configuration for redirecting YouTube links to an invidious instance:

The point of this extension was and is, that it does not have crazy permissions like access to every single website. Only youtube.com - I don't understand why those extensions make it so bloated and just use "access everything" for the sake of "its easier for me". I just want a redirector extension that redirects YOUTUBE links to piped or maybe invidious. No need for fancy stuff and to access every single domain I use in my Browser.

I mean this is kinda ridiculous for something that should just redirect a youtube link to another site...

Access browser tabs Access browser activity during navigation Access your data for all websites

MrFlyingToasterman commented 2 years ago

@eqniz Great recommendation! Have tested it out and it works wonderfully! Thank you very very much!

metiis / invidious-redirect

Makehook: fixes improper adding `www.` to redirection domains #21