search

metinkale38 / prayer-times-android

A useful Application with a set of tools needed by every muslim.
https://play.google.com/store/apps/details?id=com.metinkale.prayer
Apache License 2.0
239 stars 105 forks source link

Unexpected behaviours after a screen orientation change (reported by activity) #144

Closed datalossdetector closed 4 years ago

datalossdetector commented 4 years ago

I developed an automatic test case generation tool and it detected these problems in your app. I would like to know if you consider them as failures and, if not, why. Thanks for your collaboration.

1) When I change the orientation of the device screen, QiblaDirection activty changes the "compass" icon 2019-07-28 16-41-00_before 2019-07-28 16-41-00_after

2) When I change the orientation of the device screen, EditLocation activity doesn't keep the scroll position 2019-07-28 15-43-21_before 2019-07-28 15-43-21_after

metinkale38 commented 4 years ago

these screenshots do not refer to my app. Its another app.

datalossdetector commented 4 years ago

I'm sorry, I've downloaded your app from the Google Play Store (this time, I'm sure it's yours) and I performed the same analysis. I report here the results even if the issue has been closed yet. Could you give me a quick feedback about the problems I found? It's for research purposes. Thank you in advance!

I developed an automatic test case generation tool and it detected these problems in your app. I would like to know if you consider them as failures and, if not, why. Thanks for your collaboration.

1) When I change the orientation of the device screen, MainActivity changes its state. Below there are three different examples: the screenshots were taken before and after the screen orientation change and they are paired (before, after), (before, after) ...

-- first case -- The current page switches to the selecting language one 2019-08-10 18-15-49_before 2019-08-10 18-15-49_after

-- second case -- The current page changes 2019-08-10 18-21-38_before 2019-08-10 18-21-38_after

-- third case -- It doesn't keep the scroll position 2019-08-10 20-36-07_before 2019-08-10 20-36-07_after

metinkale38 commented 4 years ago

The first two issues seem wrong, and i could'nt reproduce the...

Case 1: Could'nt reproduce at all. The first screenshot is the main screen, and the second screen is the tutorial, which is shown once before the main screen and the tutorial is also portrait only...

Case 2: This screen is not rotatable and portrait only. The "state change" is not due to orientation change, it is because an animation, which is shown at that screen.

Case 3: Yes, scroll position is not saved, which i think, is not really an issue...