search

metio / kube-custom-resources-rs

Kubernetes Custom Resource Bindings for Rust
https://crates.io/crates/kube-custom-resources-rs
BSD Zero Clause License
20 stars 4 forks source link

Add referencegrants to kubernetes-sigs/gateway.networking.k8s.io #336

Closed banool closed 4 days ago

banool commented 4 days ago

This resource was missing from the Gateway CRDs, let's add it!

I followed the guide in https://github.com/metio/kube-custom-resources-rs/blob/main/CONTRIBUTING.md through to completion. I couldn't run steps 3 and 4 as-is, I had to set K8S_OPENAPI_ENABLED_VERSION=1.31. I didn't do anything for step 5, it seems everything worked out of the box.

Note, I had some issues with the tooling: https://github.com/metio/kube-custom-resources-rs/issues/335.

banool commented 4 days ago

Ah it turns out referencegrants are there in the code, it just isn't in the CRD files.

banool commented 4 days ago

Wait no, there are only reference grants for v1 beta and alpha, not normal v1, sorry for the confusion 😅. I see the catalog uses experimental definitions, but many of these are standard now. I updated the catalog to include all the experimental and standard files and regenerated the code. I'm not sure how you normally do this, let me know!

sebhoss commented 4 days ago

Oh yeah that's exactly what I would do as well! There have been some cases in the past where an upstream project just deleted their CRD. In those cases I think it makes sense to remove them from the catalog but keeps the CRDs in this repo because someone might depend on it. If the same CRD was just moved to another location, updating the catalog and re-running the generator.sh script should do the right thing(tm).

thanks for the help again here!