search

metmuseum / marble

Marble is the design system of The Metropolitan Museum of Art 🏛
https://marble.metmuseum.org
20 stars 5 forks source link

remove github pages deployment of storybook in favor of chromatic #194

Closed stephenhmarsh closed 2 years ago

stephenhmarsh commented 2 years ago

Our GH Pages site that's supposed to host our Storybook currently 404s. It looks like GitHub made some changes to how GH Pages get deployed that "deactivated" Pages for this repo... Possibly because gh-pages branch is now associated with Jekyll blogs?

Anyways, I really don't think we need to manually build and deploy to GH Pages anymore, in the first place, since Chromatic hosts our a copy of our main branch Storybook anyway. So we can simplify and cut some dependencies here.

JosephCurley commented 2 years ago

Our GH Pages site that's supposed to host our Storybook currently 404s. It looks like GitHub made some changes to how GH Pages get deployed that "deactivated" Pages for this repo... Possibly because gh-pages branch is now associated with Jekyll blogs?

Anyways, I really don't think we need to manually build and deploy to GH Pages anymore, in the first place, since Chromatic hosts our a copy of our main branch Storybook anyway. So we can simplify and cut some dependencies here.

Is there a URL that we can share for folks who dont have chromatic accounts? If not - I think we still want the GH page.