search

metmuseum / marble

Marble is the design system of The Metropolitan Museum of Art 🏛
https://marble.metmuseum.org
20 stars 5 forks source link

DIGCOLL-5661 style updates #198

Closed davidseguin closed 2 years ago

davidseguin commented 2 years ago

Various Marbley updates; details here: https://jira.metmuseum.org/browse/DIGCOLL-5661

davidseguin commented 2 years ago

@JosephCurley I'm glad you brought that up, it's the most important thing here. So now that $productive-width-max is a complicated formula (rather than a hard value), $spacing-component-margin is half of that and now also bit of a complicated formula. Some places that used the old $spacing-component-margin (like padding, "left" etc) can't take that calc value. So I made $spacing-soft-m which is essentially the old $spacing-component-margin (a medium-sized "soft" value based on screen width ie 7.5vw). It seemed like the best way to handle it, but obv I'm open to ideas.