search

metno / MachineOcean-WP12

Machine Ocean Work Package 1 and 2 toolbox and documentation
1 stars 3 forks source link

question about the use_atm=True default argument #20

Closed jerabaul29 closed 2 years ago

jerabaul29 commented 2 years ago

@setmar here:

https://github.com/metno/MachineOcean-WP12/blob/72072ebed8ff2610748b55e4c6bc0c8d9d9aa94a/scripts/NORA3_ERA5/NORA3_ERA5.py#L116

What is the motivation for hvaing the use_atm=True default argument? If I refactor the code for the analysis of the Uppsala data, is it ok that I just remove this parameter and the associated logics, making the logics becoming equivalent to "this parameter is like it is always True"? :) .

setmar commented 2 years ago

I think some parameters are found both in the atm and the wave files, and that this argument is used to choose which source file set you want to use.

jerabaul29 commented 2 years ago

Ok, thanks! Guess the values in both kind of files should be identical anyways? Will consider if I keep it or not :) .

setmar commented 2 years ago

Yes, I guess so too, but I did not check :)