search

metno / arcanist-support

Arcanist scripts for linters and unit tests.
11 stars 6 forks source link

Unable to use foodcritic #8

Open igolman opened 6 years ago

igolman commented 6 years ago

I followed exactly the setup procedure described in README.md, however the arcanist still refuses to use the foodcritic linter:

..
...
Loading phutil library from '/usr/local/include/php/arcanist-support/src'...
Loading phutil library from '/usr/local/include/php/arcanist-support/src'...
>>> [0] (+0) <exec> $ git rev-parse --verify HEAD^
<<< [0] (+11) <exec> 11,924 us
>>> [1] (+12) <exec> $ git merge-base 'develop' HEAD
<<< [1] (+23) <exec> 10,911 us
>>> [2] (+24) <exec> $ git diff --no-ext-diff --no-textconv --submodule=short --raw '5dbb93ed89b7bda865572b64ba211495f95d61fa' HEAD --
<<< [2] (+35) <exec> 11,759 us
>>> [3] (+36) <exec> $ git --version
<<< [3] (+46) <exec> 10,072 us
>>> [4] (+46) <exec> $ git status --porcelain=2 -z
<<< [4] (+60) <exec> 14,261 us
>>> [5] (+60) <exec> $ git diff --no-ext-diff --no-textconv --submodule=short --no-color --src-prefix=a/ --dst-prefix=b/ -U32767 -M -C '5dbb93ed89b7bda865572b64ba211495f95d61fa' --
<<< [5] (+75) <exec> 14,239 us

[2018-08-23 11:18:35] EXCEPTION: (PhutilTypeExtraParametersException) Got unexpected parameters: foodcritic at [<phutil>/src/parser/PhutilTypeSpec.php:150]
arcanist(head=master, ref.master=d9a4293ae734), miarcanist(head=master, ref.master=bf7e5d7cadc3), phutil(head=master, ref.master=5b341cc09ca9)
  #0 PhutilTypeSpec::checkMap(array, array) called at [<arcanist>/src/lint/engine/ArcanistConfigurationDrivenLintEngine.php:38]
  #1 ArcanistConfigurationDrivenLintEngine::buildLinters() called at [<arcanist>/src/lint/engine/ArcanistLintEngine.php:166]
  #2 ArcanistLintEngine::run() called at [<arcanist>/src/workflow/ArcanistLintWorkflow.php:337]
  #3 ArcanistLintWorkflow::run() called at [<arcanist>/scripts/arcanist.php:394]
michaeloa commented 6 years ago

I no longer work here and - as far as I know - MET no longer actively develops using Chef or Phabricator.

It's possible the code is out of date (i.e., arcanist has changed the way linters are written/configured), but I don't recall there being any obvious new things when I wrote a linter a few months ago. Are you able to run any of the other linters, e.g., the scalastyle one?