search

metno / emep-ctm

Open Source EMEP/MSC-W model
GNU General Public License v3.0
27 stars 18 forks source link

Absolute path to some input data files limited to 100 characters #25

Closed JohnJohanssonChalmers closed 6 years ago

JohnJohanssonChalmers commented 6 years ago

I keep all my input data on a network server and the absolute paths to the files become quite long due to a deep directory tree. This becomes a problem in some cases where the Fortran code uses strings with a fixed length of 100 characters to represent these paths. I know there may be possible workarounds (such as using symbolic links) but it would be better to eliminate this limitation. Here are the places in the code where I made changes to make it work for me:

In ModelConstants_ml.f90, line 256: character (len=100), public :: DataPath(20) = 'NOTSET'

In Met_ml.f90, line 144: character (len = 100), save :: meteoname ! name of the meteofile and line 277: character (len = 100), save :: meteoname ! name of the meteofile

I changed the string lengths to 200 characters, but maybe that could also be a limitation for someone else in the future.

avaldebe commented 6 years ago

You are correct, this might be too short. In general each module has its own path length. It would be better to set it as a constant in ModelConstants_ml and let all modules use that length.

avaldebe commented 6 years ago

Just pushed a patch addressing this issue on our R&D repository. Will keep this issue open until the next open source release.

avaldebe commented 6 years ago

This issue was addressed on our last model release (rv4_17), so I'll close the issue.