search

metno / emep-ctm

Open Source EMEP/MSC-W model
GNU General Public License v3.0
29 stars 19 forks source link

Too large integer literal in ChemReates_ml.f90 #26

Closed JohnJohanssonChalmers closed 5 years ago

JohnJohanssonChalmers commented 6 years ago

On line 136 and 137 in ChemRates_ml.f90 there are two large integer literals in the reaction rate expressions:

       rct(67,:) = 97760000*exp(-7261*TINV) 
       rct(68,:) = 1450000000000*exp(-10688*TINV)

My compiler complained about this so I had to change them to floats. Dave told me that these where generated by GenChem, so maybe that is where this should really be fixed.

avaldebe commented 6 years ago

You are correct. Your comment was forwarded by @mifads and should be fixed on our development/research branch. At the time of writing this has not yet been addressed.

avaldebe commented 6 years ago

@mifads I see that this issue was not addressed on our last release (rv4_17). Will this be dealt with on the next one?

mifads commented 6 years ago

The issue is with GenChem and that is waiting for complete replacement at some stage. On the to-do list.

avaldebe commented 5 years ago

Looks like this issue is solved on rv4_33. Please reopen if not the case.