Remove FORECAST mode

[avaldebe]

Back in the day before config_emep.nml, the FORECAST mode was introduce to set all the different options required for a forecast all in one go.

All those options are now available on on config_emep.nml, so we can cleanup:

• Basic cleanup: remove from use call and update comments
  • Advection_mod.f90
  • BoundaryConditions_mod.f90
  • ExternalBICs_mod.f90
  • ForestFire_mod.f90
  • NetCDF_mod.f90
• Light rewrite: remove from use call and update comments and
  • Config_module.f90 and config_*.nml:
  • remove FORECAST option
  • Derived_mod.f90, Config_module.f90 and config_*.nml:
  • new flag USES%SKIP_INCOMPLETE_OUTPUT to
    • skip daily output for runs under 1 day
    • skip monthly output for runs under 28 days
    • skip full-run under for runs under 181 days
  • My_Outputs_mod.f90:
  • remove deprecated/old-style hourly output
• Small rewrite: remove from use call and update comments and
  • emep_Main.f90, PhyChem_mod.f90 and ZD_Pollen/Pollen_mod.f90:
  • implement forecast restart/dump logic
  • remove zero hour output, no longer needed
  • Nest_mod.f90 and config_*.nml:
  • rename MODE_READ='FORECAST' to MODE_READ='RESTART'
  • rename MODE_WRITE='FORECAST' to MODE_WRITE='OUTDATE'
  • rename FORECAST_NDUMP and OUTDATE_NDUMP.
  • OutputChem_mod.f90, Config_module.f90 and config_*.nml:
  • new option USES%PROGRESS_FILES to output progress files, e.g. CWF_12FC-20190321_hourInst.msg for CWF_12FC-20190321_hourInst.nc, and modelrun.finished at the end of the run.

Note, this issue is also on the development repo (metno/emep-mscw#127)

[gitpeterwind]

Hi  Álvaro, Very good. One request; maybe you have done it already, otherwise please can you change this in Nest_mod.f90: in readxn , there is something like

  if(MODE_READ=='FORECAST')then
    filename_read_3D=date2string(template_read_3D,ndate,&
                                 mode='YMDH',debug=mydebug)
    filename_read_BC=date2file  (template_read_BC,ndate,BC_DAYS,"days",&
                                 mode='YMDH',debug=mydebug)
    inquire(file=filename_read_3D,exist=fexist_3D)
    inquire(file=filename_read_BC,exist=fexist_BC)
  else
    filename_read_3D=date2string(template_read_3D,ndate,&
                                 mode='YMDH',debug=mydebug)
    filename_read_BC=date2string(template_read_BC,date_nextfile,&
                                 mode='YMDH',debug=mydebug)
    fexist_3D=.true.  ! assume 3D file exists                                                                                      
    fexist_BC=.true.  ! assume BC file exists                                                                                      
  end if

Can you remove the "else" case, i.e. that in all cases the inquire is called? That part can then look like:

    filename_read_3D=date2string(template_read_3D,ndate,&
                                 mode='YMDH',debug=mydebug)
    filename_read_BC=date2file  (template_read_BC,ndate,BC_DAYS,"days",&
                                 mode='YMDH',debug=mydebug)
    inquire(file=filename_read_3D,exist=fexist_3D)
    inquire(file=filename_read_BC,exist=fexist_BC)

(no "if" anymore)

[avaldebe]

@gitpeterwind will look into your request when I reach that part of the code

[avaldebe]

@gitpeterwind do you mean to make the MODE_READ=='FORECAST' clause the only behavior?

[gitpeterwind]

yes!

[avaldebe]

done!

[avaldebe]

@heikoklein You might be interested, as the FORECAST mode was used in old versions if eEMEP. In fact, the output progress files started as a requirement from eEMEP's first implementation.

[mifads]

Looks good, except:

please revert the fullrun change. This file should be output whatever the length of the run. Thanks.

[gitpeterwind]

please revert the fullrun change. This file should be output whatever the length of the run. Thanks.

Yes, it was problematic that those files were missing when testing. I won't mind keeping monthly and daily too.

[mifads]

Actually, such a large change in outputs should have been discussed first. Then we could have said no directly ;-)

[avaldebe]

@mifads point taken.

Earlier this year @gitpeterwind asked to remove the FORECAST mode. I mentioned in person the skip month/fullrun feature, but did not elaborate... This is needed for the current forecast/analysis runs. There will be 21.535 of them this year, and creating only relevant files helps with troubleshooting. I will add a USES%SKIP_INCOMPLETE_OUTPUT flag to handle this behavior.

[avaldebe]

Closing down solved issues after rv4_32 and rv4_33. Please reopen if necessary.