search

metno / emep-ctm

Open Source EMEP/MSC-W model
GNU General Public License v3.0
27 stars 18 forks source link

case-mismatch in emiss_split inputs and the chemical species list #61

Closed douglowe closed 4 years ago

douglowe commented 4 years ago

In the latest release of the model you've changed the species strings in CM_ChemSpecs_mod.f90 from uppercase to mixed case, but the emission splitting input files are still all in uppercase. I've modified the call to find_index in my code to include the optional any_case=.true. variable - this might be worthwhile adding to the official release code too?

https://github.com/UoMResearchIT/emep-ctm/commit/5d249b8230a31a2df828629366de68cbe1d61b1d

avaldebe commented 4 years ago

We discussed this case change on our development repo. In the end we decided to modify the split files released with the model version. I do not recall the details, so I'll let @mifads and @gitpeterwind explain why it is so.

mifads commented 4 years ago

Hi Doug,

I'm just back from vacation and now have 2 working days left to finish my EMEP chapters for this year's report, as well as write up a CAMS deliverable, since next week is 100% European Aerosol Conference. I'll get back to this later, but didn't the emissplit files released with this year's code already include that case change? They should have.

douglowe commented 4 years ago

Hi,

Thanks for your quick response.

I've checked again the files I downloaded from this year's release. Indeed they do contain the change in case (and so would work fine with your code as it is currently). I had thought I'd updated my model inputs with these new files (I'm using some locally produced input files too, so didn't want to completely replace my input directory, which would have avoided this issue), but evidently had not. Apologies for the confusion.

thanks, Doug

mifads commented 4 years ago

OK. I'll close this for now, and re-open if/when we can remember why any_case wasn't used anyway.