search

metno / emep-ctm

Open Source EMEP/MSC-W model
GNU General Public License v3.0
29 stars 19 forks source link

Dry depostion request case sensitive #69

Closed mvieno closed 3 years ago

mvieno commented 4 years ago

Hi, In the namelist the DDEP_WANTED and WDEP_WANTED have a different behaviour, with DDEP been case sensitive.

For example, DDE_WANTED only accept NH4_f and in WDEP_WANTED can be either NH4_F or NH4_f.

DDEP_WANTED = 'NH4_f' ,'SPEC' ,'mgN', 'NO3_f' ,'SPEC' ,'mgN', WDEP_WANTED = 'NH4_F' ,'SPEC' ,'mgN','YMD', 'NO3_F' ,'SPEC' ,'mgN','YMD',

In the indexing function for DDEP_WANTED the “any_case=.true.” may be missing.

Massimo

mifads commented 4 years ago

We are trying to move from the older upper-case system to a newer mixed case system, where usually chemicals (C, N, etc) are kept at upper-case, and lower-case used for descriptors such as f for fine. We have used any_index=.true. in some parts of the code to get around some issues as we change systems, but I'd be inclined to move names to the new system a.s.a.p. and start to remove the any_case flexibility.

avaldebe commented 3 years ago

Hi @mvieno

@gitpeter implemented your suggestion on metno/emep-mscw#170, so this should be part on the next release (planed for this week).

I'll close this issue after the release, please reopen it if the problem persisnts

Cheers, Á.

avaldebe commented 3 years ago

rv4_36 is here...