search

metno / pyaerocom

Python tools for the AeroCom project
https://pyaerocom.readthedocs.io/
GNU General Public License v3.0
23 stars 13 forks source link

Empty colocated object when start and stop are not given #1211

Open dulte opened 3 weeks ago

dulte commented 3 weeks ago

Describe the bug The colocator returns an empty object when no start and stop are given in the colocation setup

To Reproduce Steps to reproduce the behavior:

  1. Make a colocation setup without start and stop
  2. Run a colocator with said setup
  3. The result is an empty colocated object
dulte commented 3 weeks ago

This is a bigger (design) issue than first thought. #1212 makes the tutorials work, but breaks tests.

The way it is done #1212 work to some degree, but keeps the old notion that if no start and stop are given, then pyaerocom try to infer them. More tests need to be made before this PR is ready

We have tried to make start and stop mandatory to define in colocation setup, but this breaks the tests. This is because a "default" ColocationSetup can't exist now; it must be given atleast start and stop.

We need to decide how we want ColocationSetup to work

  1. Start/stop is optional, and pyaerocom can infer them.
  2. Start/stop must be given by the user.