First try at fixing col setup without start stop. Model validator for…

metno / pyaerocom

Python tools for the AeroCom project

https://pyaerocom.readthedocs.io/

GNU General Public License v3.0

23 stars 13 forks source link

First try at fixing col setup without start stop. Model validator for… #1212

Open dulte opened 3 weeks ago

dulte commented 3 weeks ago

… pydating is also removed

Change Summary

Changes how the colocation setup and colocator handles start and stop times

Related issue number

Fix #1211

Checklist

[x] Start with a draft-PR
[x] The PR title is a good summary of the changes
[x] PR is set to AeroTools and a tentative milestone
[x] Documentation reflects the changes where applicable
[ ] Tests for the changes exist where applicable
[ ] Tests pass locally
[ ] Tests pass on CI
[x] At least 1 reviewer is selected
[ ] Make PR ready to review

dulte commented 3 weeks ago

Some test do not work due to

            if self.colocation_setup.stop is not None or not isinstance(
                self.colocation_setup.start, int
            ):
                raise ColocationSetupError(
                    "Conflict: only single year analyses are support for model "
                    'climatology fields, please specify "start" as integer '
                    'denoting the year, and set "stop"=None'
                )

part of the colocator code

lewisblake commented 1 week ago

@dulte pushing this back until September to match the milestone for the associated PR. This is the type of issue I think we should clarify at the AeroTools backend design retreat, so please keep in mind as an example.