Fixes for map-plotting of emep-results

heikoklein commented 3 months ago

Change Summary

Several fixes to get map-plotting useful for the emep-reports like

Fixing units
Fixing scales
Using a default-scale 0-10 for variables not previously defined in glob_defaults.py
removing misleading warnings

Related issue number

Checklist

[x] Start with a draft-PR
[x] The PR title is a good summary of the changes
[x] PR is set to AeroTools and a tentative milestone
[ ] Documentation reflects the changes where applicable
[ ] Tests for the changes exist where applicable
[ ] Tests pass locally
[x] Tests pass on CI
[x] At least 1 reviewer is selected
[x] Make PR ready to review

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.30%. Comparing base (a65f838) to head (ea7119c). Report is 468 commits behind head on main-dev.

Files with missing lines	Patch %	Lines
pyaerocom/aeroval/modelmaps_engine.py	0.00%	2 Missing :warning:
pyaerocom/aeroval/helpers.py	50.00%	1 Missing :warning:
pyaerocom/griddeddata.py	75.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main-dev #1220 +/- ## ============================================ - Coverage 79.30% 79.30% -0.01% ============================================ Files 131 131 Lines 20236 20239 +3 ============================================ + Hits 16048 16050 +2 - Misses 4188 4189 +1 ``` | [Flag](https://app.codecov.io/gh/metno/pyaerocom/pull/1220/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metno) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/metno/pyaerocom/pull/1220/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metno) | `79.30% <50.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metno#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

heikoklein commented 3 months ago

@AugustinMortier and @charlienegri I would like to have both your reviews, in particular with the change to using the default-range for the contours from (min-max) to (0-10).

charlienegri commented 3 months ago

as far as I can tell your cmap edit applies only to the case when var is NOT in var_ranges_defaults.keys(), so it will not affect cams2_83 (which was the scope I had edited modelmaps_engine.py within), as all the relevant variables should be in var_ranges_defaults ... so no problems for me. but Augustin is the one best equipped to evaluate this.

lewisblake commented 3 months ago

Can this be merged? @charlienegri

charlienegri commented 3 months ago

Can this be merged? @charlienegri

ok for me, Augustin is the only one who could object but I think the changes do not impact existing projects (which should have the variables listed in var_ranges_defaults)

AugustinMortier commented 3 months ago

Because those are new variables, and it's nor replacing current scales, there's no objection from my side :)

metno / pyaerocom