metno / pyaerocom

Python tools for the AeroCom project
https://pyaerocom.readthedocs.io/
GNU General Public License v3.0
23 stars 13 forks source link

MDA8 #1224

Closed thorbjoernl closed 1 week ago

thorbjoernl commented 2 weeks ago

Change Summary

Implements the possibility to calculate mda8 values for specific variables. This is done by creating an additional ColocatedData object after colocation.

Related issue number

closes #863

Checklist

thorbjoernl commented 2 weeks ago

Notes from old PR: https://github.com/metno/pyaerocom/pull/1165

Idea: O3 and CO both need MDA8. Therefore maybe making an operator which takes a ColocatedData object and applies for example a daily maximum of the 8 hourly mean (MDA8) could be useful. Would need to be specified in a config, and then dealt with here (similar to how we use use_fairmode): https://github.com/metno/pyaerocom/blob/63ca935cdea19c73ff45d960d9a91c46a384a720/pyaerocom/aeroval/coldatatojson_engine.py#L120

Want a way to keep both the original timeseries and the MDA8. Expand ColocatedDataList?

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.33%. Comparing base (48e28ea) to head (ace42f6). Report is 5 commits behind head on main-dev.

Files Patch % Lines
pyaerocom/stats/mda8/mda8.py 89.28% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main-dev #1224 +/- ## ============================================ + Coverage 79.31% 79.33% +0.02% ============================================ Files 131 133 +2 Lines 20248 20284 +36 ============================================ + Hits 16059 16092 +33 - Misses 4189 4192 +3 ``` | [Flag](https://app.codecov.io/gh/metno/pyaerocom/pull/1224/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metno) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/metno/pyaerocom/pull/1224/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metno) | `79.33% <92.68%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metno#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.