codecov[bot]
commented
4 days ago Codecov Report
Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
Project coverage is 79.33%. Comparing base (
f244a51) to head (b1fa238). Report is 1 commits behind head on main-dev.
| Files | Patch % | Lines |
|---|---|---|
| pyaerocom/io/cachehandler_ungridded.py | 70.00% | 3 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main-dev #1243 +/- ## ========================================= Coverage 79.33% 79.33% ========================================= Files 133 133 Lines 20284 20289 +5 ========================================= + Hits 16092 16096 +4 - Misses 4192 4193 +1 ``` | [Flag](https://app.codecov.io/gh/metno/pyaerocom/pull/1243/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metno) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/metno/pyaerocom/pull/1243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metno) | `79.33% <70.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metno#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Change Summary
The cache validation of ungridded data was using the pyaercom_version to identify invalid caches. Since caches and pyaerocom_version are independent, this is now only logged, but no longer used to invalidate caches.
In addition, cache validation was using ctime to identify newest files, but ctime is metadata change time, i.e. when permissions/ownerships of data changed last. This has been changed to mtime which is data modification time.
Related issue number
fixes #1242
Checklist