metno / pyaerocom

Python tools for climate and air quality model evaluation
https://pyaerocom.readthedocs.io/
GNU General Public License v3.0
26 stars 15 forks source link

Review and redesign of ColocatedData #147

Open jgliss opened 4 years ago

jgliss commented 4 years ago

Similar to #146, also ColocatedData should undergo some redefinition (but not as much as StationData. Suggestion is to turn ColocatedData.data attr. from a xarray.DataArray into a xarray.Dataset with individual DataArrays being assigned to it for model and obs separately (this would get rid of data_source dimension).

Right now I think it should still be single variable (encoded in filename).

Names of the "variables" of the Dataset could then be the obs / model IDs and would allow easy access of the individual subsets and would also make it easier to add other model or observation records. And it would also allow easier separation of global metadata (set in Dataset, e.g. pyaerocom colocation settings) and model / obs metadata (set in individual DataArray instances for both "variables").

github-actions[bot] commented 9 months ago

This issue is stale because it has been open for 365 days with no activity. This issue will be closed in 14 days if no action is taken.