search

metno / pyaro-readers

implementations of readers for the pyaerocom project using pyaro as interface
GNU Lesser General Public License v2.1
0 stars 2 forks source link

Nilupmf #31

Closed dulte closed 5 months ago

dulte commented 7 months ago

Reader for the well structured part of the NILU PMF data. Might be redundant if a new EBAS reader is implemented

dulte commented 7 months ago

Needs tests

dulte commented 7 months ago

Won't work on this until #35 is done, to see if that reader is able to read the same data

jgriesfeller commented 6 months ago

Trying to finish this for the AeroTools release since only linting was going wrong

jgriesfeller commented 6 months ago

@thorbjoernl I just realised test are missing. No need to note that in the review.

jgriesfeller commented 6 months ago

This needs a bit more work than I thought (I thought only linting was missing). But there's no tests and if one supllies a directory the data has to be in certain directory below that. This is not how is should be. Leaving the work to @dulte therefore.

jgriesfeller commented 5 months ago

small comment on the Absorption files: They are not EBAS NASA-AMES compliant (are missing vital metadata like matrix and component) and can therefore not be read with the nilupmfebas reader. The current implementation depends a bit too much on the files to have a certain format in the header, but since it works for this particular set of files, I kept @dulte 's implementation