Add revison string to the metadata of readers

metno / pyaro-readers

implementations of readers for the pyaerocom project using pyaro as interface

GNU Lesser General Public License v2.1

0 stars 2 forks source link

Add revison string to the metadata of readers #45

Closed thorbjoernl closed 2 months ago

thorbjoernl commented 3 months ago

This PR adds a revision string reflecting the dataset for various readers which can later be used for caching. The approach to derive them varies between the readers:

aeronetsdareader - Timestamp.
aeronetsunreader - Timestamp.
ascii2netcdf - Timestamp from last_changed attribute.
harpreader - Timestamp of history attribute.
netcdf_rw - Timestamp
nilupmfabsorptionreader - Timestamp
nilupmfebas - Timestamp

closes #39 closes https://github.com/metno/pyaro/issues/37

jgriesfeller commented 3 months ago

Just as a comment: historically the revision string has always been a human readable time stamp to tell the users how old the used dataset is. md5 hashes therefore might not be the best idea for a version string, since the string appears also on the aeroval web page

thorbjoernl commented 3 months ago

Just as a comment: historically the revision string has always been a human readable time stamp to tell the users how old the used dataset is. md5 hashes therefore might not be the best idea for a version string, since the string appears also on the aeroval web page

I will use timestamps when they are available. Heiko and I discussed using a hash for files which do not provide a timestamp such as some of the csv-ish formats.