search

metocean / wavespectra

MIT License
1 stars 1 forks source link

Run 2to3 on the tree #16

Closed colourcode closed 5 years ago

colourcode commented 5 years ago

To start porting it over to python3 I ran 2to3 on the repo.

Still several tests are failing.

xref: https://github.com/metocean/wavespectra/issues/15

colourcode commented 5 years ago

Several of the failing tests appear to be related to this pattern not being valid in python3 anymore:

>       return (dict(zip(dict_of_ids, x)) for x in product(*dict_of_ids.itervalues()))
E       AttributeError: 'dict' object has no attribute 'itervalues'
rafa-guedes commented 5 years ago

@colourcode I have merged your changes into a new branch py23, with a few modifications. Most of your suggestions were good but there was one important one that was not working with python2 - it was breaking the dataset plugin (I did not test it on python3 yet):

https://github.com/metocean/wavespectra/pull/16/files#diff-f64ba786dd8c8f3debd45a4801020f6fL27 https://github.com/metocean/wavespectra/pull/16/files#diff-f64ba786dd8c8f3debd45a4801020f6fL34

Also I have removed a bunch of tests in tests/broken folder that were legacy.

Will make an effort soon to try and ensure these will work on python3, so we can merge into Master.

Thanks