search

metomi / fab

Flexible build system for scientific software
https://metomi.github.io/fab/
Other
19 stars 11 forks source link

Create artefact store #285

Closed hiker closed 3 months ago

hiker commented 3 months ago

Fixes #280. It just adds a tiny new object (based on Dict) for artefact_store and adds a property to access it.

t00sa commented 3 months ago

The unit tests fail with an error in tests/unit_tests/steps/test_link.py. I suspect this is due to the use of a SimpleNamespace instance with an explicit _artefact_store dictionary.

hiker commented 3 months ago

Thanks a lot @t00sa for the (start of a) review, and my apologies for the CI failure. In PSyclone, submitting a PR triggers the CI, and then when a dev is happy, they add the label 'ready for review'. I realised later that a) no CI is triggered automatically, and b) I can't add a label :) I should have added a comment.

I am finishing this PR, but I wonder if it would be possible to get some more access so that I can add labels as required, and maybe trigger the CI (we have some more PRs coming in, one of the first one fixing the test failures we see with PSyclone 2.5). We are doing an internal review first (and I believe we now can run the test suite locally), but getting the ability to trigger the CI here would be really great, just to catch any differences between our local systems and the git CI.

t00sa commented 3 months ago

Sorry if I jumped on you PR too soon - we are still sorting out our working practices for github. I'll talk to the rest of the team about this because it seems sensible to have a way that lets you run the CI tests without immediately having someone pick up your PR for review.

I'll check with one of the project admins to see what we can do about allowing you to run the tests without requiring approval every time. The github documentation implies that it is only necessary for first time contributors, so it is possible the problem will go away once your PR is on the trunk.

hiker commented 3 months ago

Closing this for now, I have a new branch ready at https://github.com/hiker/fab/pull/8