search

metomi / fab

Flexible build system for scientific software
https://metomi.github.io/fab/
Other
19 stars 11 forks source link

Fix test warning #292

Closed jasonjunweilyu closed 3 months ago

jasonjunweilyu commented 3 months ago

This PR is to fix test warnings, either by changing them to report errors when warnings are not issued if they are designed in fab with intentions through pytest.warns() or by filtering them out if they are related to deprecation warnings in dependent packages with @pytest.mark.filterwarnings(). The motivation of this PR is explained in Issue https://github.com/hiker/fab/issues/5. The fix for test errors is in another PR.

This PR has passed the CI pipeline. It was tested to have no warnings with Python 3.12. However, there are still some Python-version-specific warnings left if you look at the CI pipeline results. The related PR on hiker/fab is here: https://github.com/hiker/fab/pull/10

Depends on

hiker commented 3 months ago

Hi Matthew, thanks a lot for the very quick review. Note that Jason is on leave, and I've asked him to put this PR in before he goes, but this PR needs to be applied after #291 (since without this patch we can't get CI to give us all green on our system, so it is dependent on that). Unfortunately, we can't (currently) set a label to indicate which PR is ready and which isn't :( I will try to fix #291 for Jason, and update this PR then.

jasonjunweilyu commented 3 months ago

Hi @MatthewHambley , I have merged metomi:master into hiker:fix_test_warning after the pull request of merging hiker:fix_test_error into metomi:master was approved. Now the duplicated change issues should have all gone, and this pull request is ready for review. Thanks.