Fix tests on non-UTC system timezones

MetRonnie commented 4 years ago

Closes #116

MetRonnie commented 4 years ago

Waiting for #159 to hopefully let the tests pass on Travis

oliver-sanders commented 4 years ago

We just need to sort out the Travis issue

Hopefully rebase on #159 should do it.

MetRonnie commented 4 years ago

Is the code coverage check actually working? (I have no experience with Codecov) From Travis:

$ "${RUN_COVERAGE:-false}" && bash <(curl -s https://codecov.io/bash)
  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                              Bash-20200430-d757c17

==> Travis CI detected.
    project root: .
    Fixing merge commit SHA
    Yaml found at: .codecov.yml
==> Running gcov in . (disable via -X gcov)
==> Python coveragepy exists disable via -X coveragepy
    -> Running coverage xml
    No data to report.
==> Searching for coverage reports in:
    + .
--> No coverage report found.
    Please visit http://docs.codecov.io/docs/supported-languages
Done. Your build exited with 0.

wxtim commented 4 years ago

Check with @oliver-sanders but I think it's been flaky/broken for at least 18 months.

oliver-sanders commented 4 years ago

No coverage would appear to be broken, it last updated one year ago - https://codecov.io/gh/metomi/isodatetime/commits.

Will raise an issue to fix, can ignore for this PR.

metomi / isodatetime

Fix tests on non-UTC system timezones #158