Speed up non-coverage test jobs

metomi / isodatetime

:date: :watch: Python ISO 8601 date time parser and data model/manipulation utilities

GNU Lesser General Public License v3.0

37 stars 20 forks source link

Closed MetRonnie closed 4 years ago

MetRonnie commented 4 years ago

Only use coverage run setup.py for the one $RUN_COVERAGE == true job, else just use python setup.py.

Approx times in minutes:

Strategy	Before	#161	Now
Ubuntu	10	25	5
Ubuntu + coverage	10	25	25
Mac	30	50	20

(my previous PR #161 fixed the path of the isodatetime module in .coveragerc)

oliver-sanders commented 4 years ago

WOW, that's how much coverage run slows things down!

oliver-sanders commented 4 years ago

Tests don't appear to have run?!

MetRonnie commented 4 years ago

Not sure why Travis isn't showing up in the checks, but it definitely ran, see the link I added above

oliver-sanders commented 4 years ago

Travis is showing a different commit number for some reason.

It's neither of these:

force-pushed the MetRonnie:fix-codecov branch from 32cc9b4 to c2c7d3d

MetRonnie commented 4 years ago

Strange... it looks like it's running what you would get if you merged into master, rather than running the tip of the PR branch.

Update: It does the same for every PR sync, if you look at the build history.

oliver-sanders commented 4 years ago

I can't see how this could break things so lets just merge it an see what happens.

MetRonnie commented 4 years ago