search

metomi / isodatetime

:date: :watch: Python ISO 8601 date time parser and data model/manipulation utilities
GNU Lesser General Public License v3.0
37 stars 20 forks source link

Replace pycodestyle with flake8 #185

Closed wxtim closed 4 years ago

wxtim commented 4 years ago

Other projects related to this one have been moving to using flake8. This change proposed for the sake of consistency.

MetRonnie commented 4 years ago

Should we add flake8 to https://github.com/metomi/isodatetime/blob/fbe537d6ecdf10af8aac6fa415a13a8c1df384b4/setup.py#L98

oliver-sanders commented 4 years ago

Yes but I let it slip since pyccodestyle wasn't there before.

If adding it there (good idea) add the tests_require to an all group so we can pip install -e .[all] as with other repos.

wxtim commented 4 years ago

I have now modified setup.py to include flake8 and the option to use pip install -e .[all]

oliver-sanders commented 4 years ago

Just waiting for tests to pass...

wxtim commented 4 years ago

I learnt a thing or two about how pip install works from this +1

Moi aussi!