Refactor TimePoint getters and fix decimal quantity dump rounding

MetRonnie commented 4 years ago

This branch was kicking around for a while; I probably meant to create a PR earlier.

Closes #180 - use only @property decorators for getter methods, instead of having a mix of those and a get(self, property_name) method
Closes #184 - fix bug where decimal quantities were getting rounded up to illegal values when dumping timepoints, e.g. minute of hour = 59.999999999 --> 60.0. Just truncate the quantity instead (in this specific circumstance), so it dumps as 59.999999 to 6 d.p.
Now prevents TimePoint from being init'd without a year (unless it's a truncated TP)

[x] Change log updated
[x] Unit tests included

MetRonnie commented 3 years ago

(The tests on Travis have passed, it's just Codacy complaining about an unassigned variable or something in a test)

oliver-sanders commented 3 years ago

BTW to make codacy happy just dedent that function and remove the unused self arg.

MetRonnie commented 3 years ago

Oh, codacy only shows the newest problem it has found with the code. Last time it was failing because of this expression-not-assigned (W0106). Trouble is, if you assign it, flake8 will flag it as an unused variable!

MetRonnie commented 3 years ago

@kinow just a reminder this is awaiting your review, no rush though

metomi / isodatetime

Refactor TimePoint getters and fix decimal quantity dump rounding #187