search

metomi / rose

:rose: Rose is a toolkit for writing, editing and running application configurations.
https://metomi.github.io/rose/
GNU General Public License v3.0
55 stars 53 forks source link

flake8 #2716

Closed oliver-sanders closed 1 year ago

oliver-sanders commented 1 year ago

Applied the flake8 fix but it failed for Python 3.7/8, pushing a test up to see in the functional tests pass with a noqa to keep flake8 happy.

wxtim commented 1 year ago

Hope you don't mind me merging my suggestion, but in this case I think it's a very small change and I was very certain that it was the correct one.

As reviewer I'm happy to say you can merge if you're happy with my change to your change. Else ask Ronnie for a quick once over.

oliver-sanders commented 1 year ago

Np,

So type(node_1) is not type(node_2) caused test failures for newer versions of Python which is interesting, so have gone down the noqa route. The comment is on two lines as the line reported appeared to change with Python version.

Please squash merge.