job-runner: fix async interaction

metomi / rose

:rose: Rose is a toolkit for writing, editing and running application configurations.

https://metomi.github.io/rose/

GNU General Public License v3.0

55 stars 50 forks source link

job-runner: fix async interaction #2785

Closed oliver-sanders closed 2 months ago

oliver-sanders commented 3 months ago

(built on #2754) Closes #2784

(hopefully this does it...)

job-runner: move finally block within async code

The job_runner is async now and runs in the background (i.e. you have to await any active tasks if you want it to be synchronous).
This means the finally block was run during the operation rather than after it.
The solution is to inline this with the async code.

wxtim commented 3 months ago

It looks reasonable, works locally for me.

You might find that something along the lines of cylc-rose/tests/functional/test_rose_stem.py might provide a pattern for setting up a fake local SVN repo to test the fileinstall on.

oliver-sanders commented 3 months ago

Thanks, I just realised we already have a repo checked out that we can test, the Rose repo! Easy enough to reproduce with a local git fileinstall.

oliver-sanders commented 3 months ago

(mac os tests squiffy ATM #2787)

oliver-sanders commented 2 months ago

Rebased onto master.