metonym / svelte-toggle

Accessible toggle switch component
https://metonym.github.io/svelte-toggle
MIT License
42 stars 5 forks source link

classic styling? #2

Closed quantuminformation closed 4 years ago

quantuminformation commented 4 years ago

seen

image

might be better for users to see it like image

metonym commented 4 years ago

Agreed. Open to PRs in this regard.

~Also, another idea would be to make the component "styleless" by default, leaving styling up to the consumer.~

Thinking back on it, the original intent was to make this component "styleless." If you're after the classic "switch" look, I'd suggest looking at something like svelte-switch.

quantuminformation commented 4 years ago

it didnt work for me and its too much bloat from react

metonym commented 4 years ago

@quantuminformation in which case I'm open to exploring the classic UI

Thinking aloud here... I see the benefit of having a classic UI look while also giving the freedom to style it however way you want it. Going even further, the Toggle could be "renderless" (i.e. a slot that passes state as props)

quantuminformation commented 4 years ago

nice one thx, I think people like me are just lazy and want it to look good and you to do the thinking

metonym commented 4 years ago

@quantuminformation svelte-toggle has been redesigned and released in v1.0.0. It incorporates changes that address several issues you've raised. Let me know if you encounter any issues.

The demo contains example use cases.

PR #5

Breaking Changes

quantuminformation commented 4 years ago

Wow you are fast man! great work!