Closed btrotta-bom closed 11 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
7e2ed68
) 98.39% compared to head (4da70df
) 98.39%. Report is 3 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for making those updates. I think this is basically there, though there are just a few follow-up items I would like addressed before approving, but these are relatively small.
One other thing is that a couple of the acceptance tests are now failing following the updates. The issue is to do with the [
'mosg__forecast_run_duration', 'mosg__model_configuratio']
attributes which are likely coming from the update to how the output cube is now created.
For some reason the comments in the review didn't carry over, so I'll add them again, but directly rather than bundled under a review.
This needs to be reviewed by BoM first. I will add the "MO review required" tag after that has happened.
This PR makes 2 changes to the rainforests calibration code:
Testing: