Closed MoseleyS closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
aaf3ae6
) 98.38% compared to head (01af03c
) 98.40%. Report is 17 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
improver.categorical.utilities.categorical_attributes improver.developer_tools.metadata_interpreter.MOMetadataInterpreter (in function run)
The categorical utilities just has a few variables called wx_keys which probably wants updating but I'm not sure about the developer_tools one?
I've updated the variable names in both files. This allows us to add other categorical data to the metadata interpreter in the future, if required.
Time spent on this ticket should be charged to a specific code. Ask @MoseleyS.
As Enhancing Post Processing Science Lead, I want the IMPROVER weather code plugin to be refactored so that I can run a precipitation type code configuration.
The essential changes are around metadata. The output cube name and categorical attributes are now derived from the decision tree, which has been updated as a result and is now also a required input to the modal categories plugin.
To achieve this, I have done some refactoring:
categorical
wxcode
->categorical
wxcode-modal
->categorical-modes
wxtree
todecision-tree
WeatherSymbols
->ApplyDecisionTree
ModalWeatherCode
->ModalCategory
Acceptance test data updates in https://github.com/metoppv/improver_test_data/pull/28
For reviewing, I recommend looking in two parts:
This PR MUST be merged with the accompanying suite PR: (https://github.com/MetOffice/improver_suite/pull/1823)
Testing: