metoppv / improver

IMPROVER is a library of algorithms for meteorological post-processing.
http://improver.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
103 stars 85 forks source link

MOBT-572: Loosen dz-scaling usage restriction. #1959

Closed bayliffe closed 11 months ago

bayliffe commented 11 months ago

Loosen dz scaling application to use the longest forecast period scaling coefficient available if no scaling coefficient has a forecast period that is longer than the forecast itself.

This will enable us to e.g. use a T+7 day scaling coefficient when calibrating a T+8 days forecast. It also means we have no warning that such use if going on. So for example, once we implement 14-day forecasts if we fail to update this ancillary with a greater range of forecast periods it will silently use the longest available.

Testing:

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (1c3b584) 98.39% compared to head (7ba91ff) 98.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1959 +/- ## ========================================== - Coverage 98.39% 98.39% -0.01% ========================================== Files 123 123 Lines 11831 11829 -2 ========================================== - Hits 11641 11639 -2 Misses 190 190 ``` | [Files](https://app.codecov.io/gh/metoppv/improver/pull/1959?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metoppv) | Coverage Δ | | |---|---|---| | [improver/calibration/dz\_rescaling.py](https://app.codecov.io/gh/metoppv/improver/pull/1959?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=metoppv#diff-aW1wcm92ZXIvY2FsaWJyYXRpb24vZHpfcmVzY2FsaW5nLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.