metoppv / improver

IMPROVER is a library of algorithms for meteorological post-processing.
http://improver.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
103 stars 85 forks source link

Explicit check of input file update times when creating weather symbols #1964

Closed bayliffe closed 11 months ago

bayliffe commented 11 months ago

This PR includes changes that allow the weather symbols CLI to check that at least one of the input files is more recent than an optionally provided update_time. If no files are more recent than this, the CLI returns without output, preventing the recreation of a weather symbol that includes no more recent input data.

This implementation needs the addition of tests if we were to adopt it.

Testing:

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0419260) 98.38% compared to head (d1358d6) 98.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 1.6.x #1964 +/- ## ======================================= Coverage 98.38% 98.38% ======================================= Files 123 123 Lines 11798 11798 ======================================= Hits 11608 11608 Misses 190 190 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bayliffe commented 11 months ago

Not necessary.