search

metoppv / improver

IMPROVER is a library of algorithms for meteorological post-processing.
http://improver.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
101 stars 84 forks source link

Categorical plugin accepts deterministic conditions #1965

Closed mspelman07 closed 7 months ago

mspelman07 commented 8 months ago

This PR makes some further changes to the wx symbols plugin so it can work with a decision tree using deterministic inputs. This PR builds on PR https://github.com/metoppv/improver/pull/1944 which refactored the code to work with any decision tree. This branch points at master but can't be merged before the previous PR.

I have attempted to write this code so that it doesn't require any changes to the current weather symbols decision tree. This is partially to limit the number of changes that need to be made but also so I can show that the changes I've made don't effect the existing decision tree.

Testing:

codecov[bot] commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3eee0a9) 98.40% compared to head (f215cb4) 98.39%.

Files Patch % Lines
improver/categorical/decision_tree.py 96.15% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1965 +/- ## ========================================== - Coverage 98.40% 98.39% -0.01% ========================================== Files 124 124 Lines 12028 12055 +27 ========================================== + Hits 11836 11862 +26 - Misses 192 193 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MoseleyS commented 8 months ago

I think I should have reassigned this to Marcus last week.