search

metoppv / improver

IMPROVER is a library of algorithms for meteorological post-processing.
http://improver.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
101 stars 84 forks source link

Optionally set a new name in max_in_height #1970

Closed mspelman07 closed 7 months ago

mspelman07 commented 7 months ago

Adds in the ability to update the name of a cube when calculating the maximum over a vertical coordinate. This is required for the EPP PR: https://github.com/MetOffice/epp_workflows/pull/17

Acceptance test data: https://github.com/metoppv/improver_test_data/pull/37

Testing:

mspelman07 commented 7 months ago

Thanks @mspelman07, this all looks fine. My only question is around whether a unit test should added as well as the acceptance test to test this new functionality?

I think you're probably right that this did need a unit test. I've now added it in.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ebbfe31) 98.39% compared to head (121567c) 98.39%.

:exclamation: Current head 121567c differs from pull request most recent head 9001bd4. Consider uploading reports for the commit 9001bd4 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1970 +/- ## ======================================= Coverage 98.39% 98.39% ======================================= Files 124 124 Lines 12057 12059 +2 ======================================= + Hits 11864 11866 +2 Misses 193 193 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.