metoppv / improver

IMPROVER is a library of algorithms for meteorological post-processing.
http://improver.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
101 stars 84 forks source link

SnowSplitter output cube names are now the same as their StaGE couterparts #1975

Closed MoseleyS closed 6 months ago

MoseleyS commented 6 months ago

Addresses https://metoffice.atlassian.net/browse/EPPT-650

While testing the EPP Precipitation Type workflows, I have found that the output cube names for rain/snow rate/accum data are not the same as the same data found on StaGE. For accumulation data, the rain and snow outputs had the names of the precipitation cube. This PR modifies the new cube name generation, which is generated from a precipitation cube name, so that:

Testing:

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c43ec0a) 97.15% compared to head (0e3cdc2) 98.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1975 +/- ## ========================================== + Coverage 97.15% 98.40% +1.24% ========================================== Files 124 124 Lines 12065 12069 +4 ========================================== + Hits 11722 11876 +154 + Misses 343 193 -150 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MoseleyS commented 6 months ago

These changes look fine, however I think additional changes are required to the acceptance test data to accommodate them. At the moment this PR causes the snow_splitter CLI acceptance tests to fail as the kgo cubes have incorrect cube names.

Oh dear. I must have been falling asleep to miss this. Acceptance Test PR added: https://github.com/metoppv/improver_test_data/pull/42