metoppv / improver

IMPROVER is a library of algorithms for meteorological post-processing.
http://improver.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
103 stars 85 forks source link

Ensure standardise CLI and plugin have identical behaviour #1986

Closed cpelley closed 4 months ago

cpelley commented 6 months ago

This is motivated by our desire to define new configurations that don't go via the IMPROVER CLI at all. Doing so requires the behaviour to be identical between the CLI layer and calling plugins directly.

We remove logic currently held in the standardise CLI layer. In this case, it wasn't moved to the standardise plugin, but instead removed entirely (update_stage_v110_metadata) as per feedback.

https://github.com/MetOffice/barebones_workflow/pull/41 is dependent on this PR

Issues

cpelley commented 5 months ago

I have opted for a ~minimal change so as to aid getting this merged and ensuring backwards compatibility (at least until we cannot continue to do so).

cpelley commented 5 months ago

Based on feedback, I have now opted for removing all the previous changes

This PR now only concerns itself with the issue of dealing with update_stage_v110_metadata. Therefore I have opted for its removal based on feedback by @bayliffe in the above comment. Nice and simple 😋

cpelley commented 4 months ago

Incorporated this CLI change into https://github.com/metoppv/improver/pull/2000 to ensure consistent approach.