Made set_up_variable_cube test helper support non-square grid cells

metoppv / improver

IMPROVER is a library of algorithms for meteorological post-processing.

http://improver.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

103 stars 85 forks source link

Made set_up_variable_cube test helper support non-square grid cells #1988

Closed MO-PeterJordan closed 5 months ago

MO-PeterJordan commented 6 months ago

Made set_up_variable_cube test helper support non-square grid cells This supports making gradient divide by distance instead of degrees. Specifically it is required to allow testing of gradient for circular coordinate systems.

Testing:

[x] Ran tests and they passed OK
[ ] Added new tests for the new feature(s) - n/a. Amended existing tests to cover new behaviour.

CLA

[x] If a new developer, signed up to CLA

MO-PeterJordan commented 6 months ago

One small tweak should fix Sphinx.

Add your name and email address to .mailmap, this should fix the Contributing check.

Done

MO-PeterJordan commented 5 months ago

Have rebased to edit original commit author to match correct name in mailmap (i.e. Peter Jordan)

MoseleyS commented 5 months ago

This still isn't happy. It seems that the commit that squashes all your previous commits together is authored by peter.jordan rather than MO-PeterJordan (use git log). The CI Test uses git shortlog -s which shows that there is just this one commit to sort out. You might need to create a new branch with the right user, then cherry-pick this one commit into it and create a new PR from it.

MO-PeterJordan commented 5 months ago

All tests now pass. Ready for re-review.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.39%. Comparing base (96cdbef) to head (d50ef06).

:exclamation: Current head d50ef06 differs from pull request most recent head 02c284b. Consider uploading reports for the commit 02c284b to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1988 +/- ## ======================================= Coverage 98.39% 98.39% ======================================= Files 124 124 Lines 12209 12212 +3 ======================================= + Hits 12013 12016 +3 Misses 196 196 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.