The tests for threshold were rewritten in PR #1913. As this comment indicates the intention was to remove the old tests once the review process was complete; they were left in place to give confidence during the review that all of the memory efficiency changes had no impact on the outputs. However, we merged the PR without deleting the old tests and renaming the new ones. This PR rectifies this mistake.
Unfortunately the git diff below makes this look horrific as I have removed test_Threshold.py and renamed test_ThresholdPytest.py to test_Threshold.py, so it is trying to diff as if one has become the other. This PR is just a deletion and a rename of the existing test files.
The tests for threshold were rewritten in PR #1913. As this comment indicates the intention was to remove the old tests once the review process was complete; they were left in place to give confidence during the review that all of the memory efficiency changes had no impact on the outputs. However, we merged the PR without deleting the old tests and renaming the new ones. This PR rectifies this mistake.
Unfortunately the git diff below makes this look horrific as I have removed
test_Threshold.pyand renamedtest_ThresholdPytest.pytotest_Threshold.py, so it is trying to diff as if one has become the other. This PR is just a deletion and a rename of the existing test files.Testing: