`apply_bias_correction` CLI does not raise ValueError when forecast cube is missing - Githubissues

metoppv / improver

IMPROVER is a library of algorithms for meteorological post-processing.

http://improver.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

101 stars 84 forks source link

`apply_bias_correction` CLI does not raise ValueError when forecast cube is missing #1994

Closed benowen-bom closed 1 month ago

benowen-bom commented 2 months ago

Recent hindcast experiments involving the use of apply_bias_correction have highlighted a bug where the CLI will use one of the forecast_error_ (bias) cubes as the forecast, and process and return this as the forecast cube. Proper handling of this situation should recognise forecast cube is missing.

Acceptance criteria:

replicate the behaviour via appropriate acceptance tests
add functionality to separate out forecast cube from forecast_error (bias) cubes based on the variable names
acceptance tests passing following updates

benowen-bom commented 1 month ago

This issue was resolved in https://github.com/metoppv/improver/pull/1995.