Closed bayliffe closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.41%. Comparing base (
84a8944
) to head (839a422
). Report is 8 commits behind head on master.:exclamation: Current head 839a422 differs from pull request most recent head b9c944e
Please upload reports for the commit b9c944e to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Prior to adding new functionality to the spot-extract plugins it was necessary to simplify the CLI inline with the changes that are needed for implementing IMPROVER configurations using DAGRunner. These changes are:
neighbour_finding_method_name
functionality a utility as it is used in several places. This includes the creation of a new unit test file for these spot-data utilities.check_grid_match
utility from the spotdata module to the metadata module where the related functionality lives.Pt 2 of this work will add the functionality to extract a subset of spot sites from an existing spot-forecast cube using the spot-extract CLI / SpotManipulation plugin. This was large enough so I've stopped here to split it up, though Pt 2 should be much smaller.
Testing: