Closed cpelley closed 2 months ago
...should we be using upper case? Not too worried, but others might be.
Indeed. I wont get away with this 😋
You've not modified the bin/improver or bin/improver-tests files, which have slightly different license headers...
Ah, thanks. I'll take a look.
This documentation doc/source/Code-Style-Guide.rst still lists the old header...
👍
Thanks for the feedback @bayliffe
As IAG for science code, I can attest to the fact that the license header needn't be so elaborate. Furthermore, marking files with a UTF-8 header was more relevant in older versions of Python, specifically before Python 3.0, to ensure correct interpretation of non-ASCII characters. I can't think of a reason why this is included in IMPROVER headers. (noticed this while adding new files as part of https://github.com/metoppv/improver/pull/2000)
Issues