Closed cpelley closed 2 months ago
Finally got this ready for review. This covers the second and final chunk of IMPROVER CLI/plugin changes required specifically for EPP. Cheers
@bayliffe, directly relevant change in reflection of this work in https://github.com/MetOffice/dagrunner/pull/40 (you need not review that, I mention only out of interest).
Changes based on feedback from @bayliffe:
improver/cli/extract.py
.
improver_tests/utilities/cube_extraction/test_ExtractSubCube.py
to reflect this change in behaviour to the plugin.improver.utilities.complex_conversion.deg_to_complex
.deg_to_complex
and complex_to_deg
from WindDirection
.improver_tests/wind_calculations/wind_direction/test_WindDirection.py
to new file improver_tests/utilities/complex_conversion/test_integration.py
(roundtrip testing).
improver_tests/wind_calculations/wind_direction/test_WindDirection.py
to ensure successful running of tests that remain.The only thing I haven't done as I'm not quite following is what the issue is, is in regards to https://github.com/metoppv/improver/pull/2003#discussion_r1665628061
However, I responded to what I think is a misunderstanding. *args
is being passed to the function. The idea is just 1 parameter could be passed if its a cubelist, or 2 or 3 etc. I have verified that the documentation does highlight what data is actually needed to be provided.
You happy to approve @bayliffe?
cheers
I suspect the CI failures with Sphinx are unrelated to this PR (a result of changes in the conda-forge conda environment, prob. needs something pinning or something unpinning). Fix for CI in https://github.com/metoppv/improver/pull/2011
I have merged in master into this branch and changed the target (since subset 1 was merged I forgot to change it here).
@mo-robert-purvis, you mind approving once more (it removed your approval after I changed the target to master). cheers
I just merged master into this branch to resolve the CI failure.
Thanks both. @bayliffe, I have made the leadtimes optional once more. Thanks for double checking this for me.
Second/final chunk of plugin changes required by EPP.
Tasks
Issues