search

metosin / jsonista

Clojure library for fast JSON encoding and decoding.
https://cljdoc.org/d/metosin/jsonista
Eclipse Public License 2.0
422 stars 30 forks source link

Perf graphs seem strange #21

Closed joelittlejohn closed 5 years ago

joelittlejohn commented 5 years ago

Hi. It looks like jsonista takes the same amount of time to encode 10b as it does to encode 100Kb. Am I reading these graphs incorrectly?

When I looked at the perf tests, I see comments in the code that appear to show more realistic results. Maybe something went wrong rendering the graphs to PNG?

hlship commented 5 years ago

I think the charts show relative costs (if so, should be labeled as such!)

joelittlejohn commented 5 years ago

Ah I see, thanks @hlship!

ikitommi commented 5 years ago

It is relative cost. Ideas welcome on what would be a good way to fix this for good? Change the title? Change the charts, how?

hlship commented 5 years ago

I know I'd prefer to see raw numbers, and group by test type, rather than by framework, so that the cheshire and jsonista versions were side-by-side.

On Thu, Aug 8, 2019 at 6:25 AM Tommi Reiman notifications@github.com wrote:

It is relative cost. Ideas welcome on what would be a good way to fix this for good? Change the title? Change the charts, how?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/metosin/jsonista/issues/21?email_source=notifications&email_token=AAAM3NANWZ47DSPSBKD5Q73QDQNFLA5CNFSM4IEIBEP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD33TFQY#issuecomment-519516867, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAM3NG5KHV7Z6AER5UBE3LQDQNFLANCNFSM4IEIBEPQ .

-- Howard M. Lewis Ship

Senior Mobile Developer at Walmart Labs

(971) 678-5210 http://howardlewisship.com @hlship