Testing utilities

[ikitommi]

common helpers for malli assertions for tests. Can be done in user space, but, might be handy as a ns like malli.test.

From Slack:

aaron51 21 hours ago Yes, it is straightforward enough to write it in user space. But I thought it would be a common case… Found a few similar things: schema: https://github.com/plumatic/schema/blob/master/test/clj/schema/test_macros.clj schema: https://github.com/plumatic/schema/blob/master/test/cljx/schema/core_test.cljx clojure-expectations has “spec expectations” https://github.com/clojure-expectations/clojure-test

borkdude 21 hours ago I also have this one: https://github.com/borkdude/respeced This was written to test fdef specs.

[ikitommi]

relates to #349

[apeckham]

We're using this to write clojure.test assertions like (is (valid [:int] "asdf")). Would you like it as a PR in malli.test?

(defmethod t/assert-expr 'valid
  [msg [_ schema data]]
  `(let [is-valid?# (m/validate ~schema ~data)]
     (t/do-report {:actual ~data
                   :expected (-> ~schema
                                 (m/explain ~data)
                                 (me/humanize))
                   :message ~msg
                   :type (if is-valid?# :pass :fail)})))

Failures look like:

FAIL in () (util_test.clj:14)
expected: ["should be an integer"]
  actual: "asdf"

[devurandom]

Metabase's test runner has something similar:

• https://github.com/metabase/hawk/blob/f8d80bce903fb503399eaf3e55ebb19d43d49a92/src/mb/hawk/assert_exprs.clj#L101-L111
• https://github.com/metabase/hawk/blob/f8d80bce903fb503399eaf3e55ebb19d43d49a92/src/mb/hawk/assert_exprs/approximately_equal.clj#L165-L188

[devurandom]

(defmethod t/assert-expr 'valid
  [msg [_ schema data]]
  `(let [is-valid?# (m/validate ~schema ~data)]
     (t/do-report {:actual ~data
                   :expected (-> ~schema
                                 (m/explain ~data)
                                 (me/humanize))
                   :message ~msg
                   :type (if is-valid?# :pass :fail)})))

Will this evaluate schema and data three times, once for is-valid?#, once for actual, and again for expected?

I am using this version now:

(defmethod test/assert-expr 'validate
  [msg [_ schema actual]]
  ;; Prevent double-evaluation of `schema` and `actual`:
  `(let [schema# ~schema
         actual# ~actual]
     (test/do-report
      {:type     (if (m/validate schema# actual#) :pass :fail)
       :message  ~msg
       :expected (me/humanize (m/explain schema# actual#))
       :actual   actual#})))