search

metosin / malli

High-performance data-driven data specification library for Clojure/Script.
Eclipse Public License 2.0
1.46k stars 208 forks source link

Fix malli swagger defs #863

Closed cap10morgan closed 1 year ago

cap10morgan commented 1 year ago

These are changes I needed to make in here to fix https://github.com/metosin/reitit/issues/558 (I will be issuing a PR for the changes needed in reitit soon too).

cap10morgan commented 1 year ago

Note that if you use any recursive schemas, you'll still see some missing defs in your swagger due to #464.

opqdonut commented 1 year ago

Good stuff! Moving the malli swagger generation from reitit to malli would be consistent with what we do with spec & schema.

cap10morgan commented 1 year ago

@opqdonut Is this just waiting on some tests for swagger-spec now?

opqdonut commented 1 year ago

Yeah, just waiting for tests.

See my comment for one possible test case.

cap10morgan commented 1 year ago

OK @opqdonut I think this is ready for re-review. I even added a (commented-out) failing test for #464.