Malli generates circular json-schema

[opqdonut]

... at least for mu/closed schemas

(require '[malli.util :as mu])
(require 'malli.json-schema)
(malli.json-schema/transform (mu/closed-schema [:schema {:registry {"Foo" :int}} "Foo"]))
 ==> {:$ref "#/definitions/Foo", :definitions {"Foo" {:$ref "#/definitions/Foo"}}}  ;; wrong, circular schema
(malli.json-schema/transform [:schema {:registry {"Foo" :int}} "Foo"])
 ==> {:$ref "#/definitions/Foo", :definitions {"Foo" {:type "integer"}}} ;; right

863 seems to fix this.

[cap10morgan]

@opqdonut Should this be closed now too since #863 was merged?

[opqdonut]

I'll do some more testing and see if I can find any other corner cases.

[opqdonut]

Mutual recursion still doesn't work:

user=> (malli.json-schema/transform [:schema {:registry {"Foo" [:vector [:ref "Bar"]] "Bar" [:ref "Foo"]}} "Foo"])
{:$ref "#/definitions/Foo", :definitions {"Foo" {:type "array", :items {:$ref "#/definitions/Bar"}}}}

[ikitommi]

Fixed in master:

(malli.json-schema/transform [:schema {:registry {"Foo" [:vector [:ref "Bar"]] "Bar" [:ref "Foo"]}} "Foo"])
;{:$ref "#/definitions/Foo",
; :definitions {"Foo" {:type "array", :items {:$ref "#/definitions/Bar"}}
;               "Bar" {:$ref "#/definitions/Foo"}}}