metosin / malli

High-performance data-driven data specification library for Clojure/Script.
Eclipse Public License 2.0
1.44k stars 205 forks source link

Add cherry as alternative CLJS evaluator #888

Closed borkdude closed 1 year ago

borkdude commented 1 year ago

@ikitommi I'm sure you have some feedback, fire away. I think I should add some docs on how to enable cherry with malli. In short: just add the cherry dependency and require malli.cherry.

borkdude commented 1 year ago

A small additional note:

To use SCI + cherry in one advanced build you need to use the newest commit from CLJS, except if you are using shadow-cljs:

https://github.com/clojure/clojurescript/commit/0ccd19fc79f04a5082764901bd6413a5841ca428

ikitommi commented 1 year ago

Needed 721eb361b5064ffa6b7fd4f072a27baed8096e3e so that the bundle size test app still work, e.g.

npx shadow-cljs run shadow.cljs.build-report app /tmp/report.html
npx shadow-cljs run shadow.cljs.build-report app-sci /tmp/report.html #failed

npx shadow-cljs run shadow.cljs.build-report app2 /tmp/report.html
npx shadow-cljs run shadow.cljs.build-report app2-sci /tmp/report.html #failed
ikitommi commented 1 year ago

Happy to merge this already, but if you could write a quick how-to into README, that would be awesome.

Maybe add shadow :build for cherry too to see the effects on bundle size?

borkdude commented 1 year ago

@ikitommi OK, I'll update the README and a shadow build.

borkdude commented 1 year ago

@ikitommi Done

report.html.txt

ikitommi commented 1 year ago

Beutifull, thanks!!